Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete button in order to make product name clickable in Sidebar #21101 #27605

Closed
wants to merge 1 commit into from
Closed

Fix delete button in order to make product name clickable in Sidebar #21101 #27605

wants to merge 1 commit into from

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Apr 4, 2020

Description (*)

Some previous fixes for delete button in Sidebar's Wishlist and Compare widget were conflicting with each other making delete button full width and on top of product name. Therefore the user was unable to click product name.

By refactoring styles of delete button with general position on the right side and then with specific styling for Compare and Wishlist widgets products list, we keep previous fixes and also allow user to click product name and be redirected to PDP.

Related Pull Requests

Fixed Issues (if relevant)

  1. Unable to open the product from sidebar's Compare Products block #21101: Unable to open the product from sidebar's Compare Products block

Manual testing scenarios (*)

  1. Add a product to your Compare Products list
  2. Add a product to your Wishlist
  3. Go to page where you can see Compare Products and Wishlist in the sidebar (e.g. Category Page/User Area)
  4. Check if:
  • delete button is on the left side of product name in Compare Products widget
  • delete button is on the right side of product name in Wishlist
  • user can click on product name in Compare Products widget
  • user can click on product name in Wishlist

Repeat for Luma and Blank theme.

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 4, 2020
@edenduong
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-27605.instances.magento-community.engineering/admin_e643
Login: 41adcc06 Password: 5379e5fa301f
Instance will be terminated in up to 3 hours.

@edenduong edenduong self-assigned this Apr 5, 2020
edenduong
edenduong approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 5, 2020
@edenduong edenduong added Award: bug fix Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Apr 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7267 has been created to process this Pull Request
✳️ @edenduong, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@eduard13
Copy link
Contributor

eduard13 commented Apr 5, 2020 •
edited
Loading

Hi @ptylek, thank you for your fix, however there is already an opened PR #27451 that fixes the issue, moreover it is covered by automated tests. So have to close this one in favor of that one.
If you bring some other improvements, please do it separately, and also make sure to cover them by automated tests.
Thanks.

@eduard13 eduard13 closed this Apr 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2020

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost removed this from Ready for Testing in Pull Requests Dashboard Apr 5, 2020
@ptylek
Copy link
Contributor Author

ptylek commented Apr 5, 2020

@eduard13 Okay, I will. I didn't notice anyone being assigned to the issue that's why I worked on this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenduong edenduong edenduong approved these changes

Assignees

@edenduong edenduong

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Event: Global-Contribution-Day Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ptylek @edenduong @magento-engcom-team @eduard13